PS4 was an OK upgrade I suppose. Honestly, I just bought it more for the awesome God of War LE paint job and DS4. I think I'm lucky because my PS4 Pro is pretty freakin' quiet. I don't think I've ever heard it in the 2-300 hours I've used it for. Maybe a handful of times, but I beat TLOU2 and don't remember hearing anything.
Xbox One X, however, was a definite upgrade and offered a few more benefits that appealed to me, specifically the BC X1X enhancements. The killing off of the Kinect port and the fact that the official adapters are super expensive now definitely sucks though. It's pretty quiet, smaller and sleeker and a worthy upgrade over the base Xbox One.
However, since gaming is my #1 hobby and I don't mind pouring money into it, I don't really regret either purchase. If I was just your average Joe? Eh.... yeah I think I would regret it.