A guy that can get the best and exclusive photos of Spider-man, villians, and other heroes could make a killing selling them, have a ton of social media followers, and could do well on youtube if he shot video.
I mean yeah, you're right, but part of what makes Spider-Man an endearing character is he tries to do "average people" jobs. Pizza delivery, take photos, etc. That way of making money is too far from how the average person makes money for it to work for how the character is written.
Like let's be honest here, Peter Parker is a genius that has very few people on the planet alive that are smarter than him (Reed Richards, Octavius, Doctor Doom etc level of smarts are the only ones better basically). Guy could legitimately work at pretty much any technological position he wants and make bank off of his intelligence.
He doesn't because that's not average.
Peter isn't broke by happenstance, he's broke by choice, essentially.