I think either Switch Pro or Xbox one standard controller are my favorite from this gen. Pro has a bad d-pad (that I almost never use tbh), but it has amazing battery life, robust build and good grab feeling. Xbox One has a better d-pad, but Rb/Lb are not that good and have a good amount of button surface that can't be used as a button, if that makes sense. The triggers are more comfortable than Pro's though.
On the other hand, the DS4 is the worst one by a wide margin IMO: it feels cheap (it creaks a lot if you grab it using some force), the battery life is shit, the backlight is one of the worst controller features ever...
Maybe the Pro is a little bit too expensive, but if you play a lot of Docked games it's a great inversion, the joycons don't feel that great during long sessions.